Added ConnectorSettings class.

Added ConnectorSettings class to reduce number of arguments and members in cloud print service.

BUG=137129
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158149

[Vitaly Buka (NO REVIEWS), 2012-09-21 16:18:53]

Please review.
Lei, I need OWNER's review for chrome.gyp

[Lei Zhang, 2012-09-21 20:26:22]

This generally lgtm, but you should get someone more familiar with GCP to review
this too.

https://chromiumcodereview.appspot.com/10968031/diff/7023/chrome/service/clou...
File chrome/service/cloud_print/connector_settings.cc (right):

https://chromiumcodereview.appspot.com/10968031/diff/7023/chrome/service/clou...
chrome/service/cloud_print/connector_settings.cc:13: const char
kDeleteOnEnumFail[] = "delete_on_enum_fail";
nit: this goes in an anonymous namespace.

https://chromiumcodereview.appspot.com/10968031/diff/7023/chrome/service/clou...
File chrome/service/cloud_print/connector_settings.h (right):

https://chromiumcodereview.appspot.com/10968031/diff/7023/chrome/service/clou...
chrome/service/cloud_print/connector_settings.h:58:
DISALLOW_COPY_AND_ASSIGN(ConnectorSettings);
nit: add a newline before this.

[Vitaly Buka (NO REVIEWS), 2012-09-21 20:36:37]

Thanks, sure I'll wait Albert or Gene.

https://chromiumcodereview.appspot.com/10968031/diff/7023/chrome/service/clou...
File chrome/service/cloud_print/connector_settings.cc (right):

https://chromiumcodereview.appspot.com/10968031/diff/7023/chrome/service/clou...
chrome/service/cloud_print/connector_settings.cc:13: const char
kDeleteOnEnumFail[] = "delete_on_enum_fail";
On 2012/09/21 20:26:22, Lei Zhang wrote:
> nit: this goes in an anonymous namespace.

Done.

https://chromiumcodereview.appspot.com/10968031/diff/7023/chrome/service/clou...
File chrome/service/cloud_print/connector_settings.h (right):

https://chromiumcodereview.appspot.com/10968031/diff/7023/chrome/service/clou...
chrome/service/cloud_print/connector_settings.h:58:
DISALLOW_COPY_AND_ASSIGN(ConnectorSettings);
On 2012/09/21 20:26:22, Lei Zhang wrote:
> nit: add a newline before this.

Done.

[gene, 2012-09-21 22:08:36]

https://chromiumcodereview.appspot.com/10968031/diff/13004/chrome/service/clo...
File chrome/service/cloud_print/connector_settings.cc (right):

https://chromiumcodereview.appspot.com/10968031/diff/13004/chrome/service/clo...
chrome/service/cloud_print/connector_settings.cc:61:
print_system_settings_.reset(source.print_system_settings()->DeepCopy());
copy remove_missing_printers_ as well here?

https://chromiumcodereview.appspot.com/10968031/diff/13004/chrome/service/clo...
File chrome/service/cloud_print/connector_settings.h (right):

https://chromiumcodereview.appspot.com/10968031/diff/13004/chrome/service/clo...
chrome/service/cloud_print/connector_settings.h:36: bool
remove_missing_printers() const {
Can we rename this? Meaning of this flag is to remove printers when we don't
have a full list. If we do have a full list, we always remove printers
regardless of this flag.
so, may be allow_partial_list_printer_deletes() ???

https://chromiumcodereview.appspot.com/10968031/diff/1040/chrome/service/clou...
File chrome/service/cloud_print/connector_settings.cc (right):

https://chromiumcodereview.appspot.com/10968031/diff/1040/chrome/service/clou...
chrome/service/cloud_print/connector_settings.cc:15: const char
kDeleteOnEnumFail[] = "delete_on_enum_fail";
nit: since the logic for URL and settings are now encapsulated in this class
only, it may make sense to more some constants from cloud_print_consts.h here.

[Vitaly Buka (NO REVIEWS), 2012-09-21 22:34:09]

https://chromiumcodereview.appspot.com/10968031/diff/13004/chrome/service/clo...
File chrome/service/cloud_print/connector_settings.h (right):

https://chromiumcodereview.appspot.com/10968031/diff/13004/chrome/service/clo...
chrome/service/cloud_print/connector_settings.h:36: bool
remove_missing_printers() const {
On 2012/09/21 22:08:36, gene wrote:
> Can we rename this? Meaning of this flag is to remove printers when we don't
> have a full list. If we do have a full list, we always remove printers
> regardless of this flag.
> so, may be allow_partial_list_printer_deletes() ???

Done.

[Vitaly Buka (NO REVIEWS), 2012-09-21 22:35:28]

https://chromiumcodereview.appspot.com/10968031/diff/13004/chrome/service/clo...
File chrome/service/cloud_print/connector_settings.cc (right):

https://chromiumcodereview.appspot.com/10968031/diff/13004/chrome/service/clo...
chrome/service/cloud_print/connector_settings.cc:61:
print_system_settings_.reset(source.print_system_settings()->DeepCopy());
On 2012/09/21 22:08:36, gene wrote:
> copy remove_missing_printers_ as well here?

Done.

[Vitaly Buka (NO REVIEWS), 2012-09-21 22:39:20]

https://chromiumcodereview.appspot.com/10968031/diff/1040/chrome/service/clou...
> chrome/service/cloud_print/connector_settings.cc:15: const char
> kDeleteOnEnumFail[] = "delete_on_enum_fail";
> nit: since the logic for URL and settings are now encapsulated in this class
> only, it may make sense to more some constants from cloud_print_consts.h here.

Done.

[gene, 2012-09-21 22:50:35]

lgtm

[commit-bot: I haz the power, 2012-09-21 22:50:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10968031/1053

[commit-bot: I haz the power, 2012-09-22 02:13:12]

Change committed as 158149