Issue 10967081: Remove dependency of plugin infobar delegates on PluginObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10967081: Remove dependency of plugin infobar delegates on PluginObserver. (Closed)

Created:
8 years, 2 months ago by Bernhard Bauer

Modified:
8 years, 2 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove dependency of plugin infobar delegates on PluginObserver. PluginObserver is a pure observer, so it doesn't really need a public interface. BUG=nope Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158667

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -22 lines)			Patch
M	chrome/browser/plugins/plugin_infobar_delegates.h	View	1 2	3 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/plugins/plugin_infobar_delegates.cc	View		4 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/plugins/plugin_observer.h	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/plugins/plugin_observer.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10967081/6001

8 years, 2 months ago (2012-09-24 21:21:10 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...

8 years, 2 months ago (2012-09-25 00:35:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10967081/6001

8 years, 2 months ago (2012-09-25 20:50:02 UTC) #5

Change committed as 158667