Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 10967071: Fix applying svn:executable on Windows. (Closed)

Created:
8 years, 2 months ago by M-A Ruel
Modified:
8 years, 2 months ago
Reviewers:
Peter Mayo
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, Isaac (away), michaelbai
Visibility:
Public.

Description

Fix applying svn:executable on Windows. For an unknown reason, 'svn propset svn:executable * foo.sh' doesn't work on Windows. It is even more awkward that 'svn propset svn:executable . foo.sh' works just fine, in particular, subversion replaces the value, as long as it's not an empty string, back to '*'. R=petermayo@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M checkout.py View 1 chunk +4 lines, -1 line 0 comments Download
M patch.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/patch_test.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
8 years, 2 months ago (2012-09-24 15:08:38 UTC) #1
Peter Mayo
lgtm
8 years, 2 months ago (2012-09-24 15:18:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10967071/1
8 years, 2 months ago (2012-09-24 15:25:28 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-09-24 15:28:53 UTC) #4
Change committed as 158281

Powered by Google App Engine
This is Rietveld 408576698