Chromium Code Reviews
Help | Chromium Project | Sign in
(447)

Issue 10967043: Add ability to open/close ash desktop via hot dogs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by grt
Modified:
1 year, 6 months ago
CC:
chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, robertshield
Visibility:
Public.

Description

Add ability to open/close ash desktop via hot dogs.

Run chrome.exe --enable-ash for the menu item to appear.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158943

Patch Set 1 #

Patch Set 2 : USE_ASH #

Patch Set 3 : ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Lint Patch
M chrome/app/chrome_command_ids.h View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/ash/ash_util.h View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/ash/ash_util.cc View 2 chunks +8 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 chunks +13 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 chunks +13 lines, -0 lines 0 comments ? errors Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 12
grt
Hi Ben, This is the first step in the "two worlds" change.
1 year, 6 months ago #1
Ben Goodger (Google)
lgtm
1 year, 6 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10967043/1
1 year, 6 months ago #3
I haz the power (commit-bot)
Failed to apply patch for chrome/common/chrome_switches.h: While running patch -p1 --forward --force; patching file chrome/common/chrome_switches.h ...
1 year, 6 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10967043/2002
1 year, 6 months ago #5
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
1 year, 6 months ago #6
grt
Hi Ben, I've added USE_ASH guards around my additions here. PTAL. Thanks.
1 year, 6 months ago #7
Ben Goodger (Google)
I think this is fine lgtm
1 year, 6 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10967043/6004
1 year, 6 months ago #9
I haz the power (commit-bot)
Retried try job too often for step(s) build
1 year, 6 months ago #10
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10967043/23001
1 year, 6 months ago #11
I haz the power (commit-bot)
1 year, 6 months ago #12
Change committed as 158943
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434