Avoid calling RWHVWin::GetBackingStore when accelerated compositing is enabled.

Avoid calling RWHVWin::GetBackingStore when accelerated compositing is enabled.

It's milliseconds expensive and it's not needed in this case.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157915

[apatrick_chromium, 2012-09-20 22:14:17]

PTAL.

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_win.cc:1309: if
(!render_widget_host_)
This is is a bit suspicious and I can fix it if you agree. I think OnPaint must
call BeginPaint and EndPaint or bad things happen. This should be immediately
below thee definition of paint_dc.

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_win.cc:1316:
base::win::ScopedGDIObject<HRGN> damage_region(CreateRectRgn(0, 0, 0, 0));
This has to be above the definition of paint_dc as the comment says.

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_win.cc:1319: CPaintDC
paint_dc(m_hWnd);
This moved up so everything uses a single definition of paint_dc.

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_win.cc:1337: if
(accelerated_surface_.get() &&
And this moved above the call to GetBackingStore.

[sky, 2012-09-20 22:39:52]

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_win.cc:1309: if
(!render_widget_host_)
On 2012/09/20 22:14:17, apatrick_chromium wrote:
> This is is a bit suspicious and I can fix it if you agree. I think OnPaint
must
> call BeginPaint and EndPaint or bad things happen. This should be immediately
> below thee definition of paint_dc.

Agreed.

[apatrick_chromium, 2012-09-20 22:52:31]

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

https://codereview.chromium.org/10967027/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_win.cc:1309: if
(!render_widget_host_)
On 2012/09/20 22:39:52, sky wrote:
> On 2012/09/20 22:14:17, apatrick_chromium wrote:
> > This is is a bit suspicious and I can fix it if you agree. I think OnPaint
> must
> > call BeginPaint and EndPaint or bad things happen. This should be
immediately
> > below thee definition of paint_dc.
> 
> Agreed.

Done.

[sky, 2012-09-20 22:56:41]

LGTM

[commit-bot: I haz the power, 2012-09-20 23:03:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/10967027/5001

[commit-bot: I haz the power, 2012-09-21 03:40:59]

Change committed as 157915