Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3747)

Unified Diff: chrome/browser/ui/webui/instant_ui.cc

Issue 10967022: alternate ntp: persist show-search-provider-logo option at chrome://instant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/instant_ui.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/instant_ui.cc
diff --git a/chrome/browser/ui/webui/instant_ui.cc b/chrome/browser/ui/webui/instant_ui.cc
index 57ce618e817e19b9ebbb356d709ebae0d24fcee2..f383b92bf8745315a1e5f14a006793fa70aabfcd 100644
--- a/chrome/browser/ui/webui/instant_ui.cc
+++ b/chrome/browser/ui/webui/instant_ui.cc
@@ -44,10 +44,6 @@ class InstantUIMessageHandler
return slow_animation_scale_factor_;
}
- static bool show_search_provider_logo() {
- return show_search_provider_logo_;
- }
-
private:
void GetPreferenceValue(const base::ListValue* args);
void SetPreferenceValue(const base::ListValue* args);
@@ -55,15 +51,11 @@ class InstantUIMessageHandler
// Slows down Instant animations by a time factor.
static int slow_animation_scale_factor_;
- // True if search provider logo should be shown.
- static bool show_search_provider_logo_;
-
DISALLOW_COPY_AND_ASSIGN(InstantUIMessageHandler);
};
// static
int InstantUIMessageHandler::slow_animation_scale_factor_ = 1;
-bool InstantUIMessageHandler::show_search_provider_logo_ = false;
InstantUIMessageHandler::InstantUIMessageHandler() {}
@@ -94,7 +86,8 @@ void InstantUIMessageHandler::GetPreferenceValue(const base::ListValue* args) {
web_ui()->CallJavascriptFunction(
"instantConfig.getPreferenceValueResult", pref_name_value, arg);
} else if (pref_name == prefs::kInstantShowSearchProviderLogo) {
- base::FundamentalValue arg(show_search_provider_logo_);
+ PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
+ base::FundamentalValue arg(prefs->GetBoolean(pref_name.c_str()));
web_ui()->CallJavascriptFunction(
"instantConfig.getPreferenceValueResult", pref_name_value, arg);
} else if (pref_name == prefs::kExperimentalZeroSuggestUrlPrefix) {
@@ -124,7 +117,8 @@ void InstantUIMessageHandler::SetPreferenceValue(const base::ListValue* args) {
bool value;
if (!args->GetBoolean(1, &value))
return;
- show_search_provider_logo_ = value;
+ PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
+ prefs->SetBoolean(pref_name.c_str(), value);
} else if (pref_name == prefs::kExperimentalZeroSuggestUrlPrefix) {
std::string value;
if (!args->GetString(1, &value))
@@ -153,6 +147,16 @@ int InstantUI::GetSlowAnimationScaleFactor() {
}
// static
-bool InstantUI::ShouldShowSearchProviderLogo() {
- return InstantUIMessageHandler::show_search_provider_logo();
+bool InstantUI::ShouldShowSearchProviderLogo(
+ content::BrowserContext* browser_context) {
+ PrefService* prefs = Profile::FromBrowserContext(browser_context)->GetPrefs();
+ return prefs->GetBoolean(prefs::kInstantShowSearchProviderLogo);
+}
+
+// static
+void InstantUI::RegisterUserPrefs(PrefService* user_prefs) {
+ user_prefs->RegisterBooleanPref(prefs::kInstantShowSearchProviderLogo, false,
+ PrefService::UNSYNCABLE_PREF);
+ user_prefs->RegisterStringPref(prefs::kExperimentalZeroSuggestUrlPrefix, "",
+ PrefService::UNSYNCABLE_PREF);
}
« no previous file with comments | « chrome/browser/ui/webui/instant_ui.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698