Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4771)

Unified Diff: chrome/common/extensions/extension_action.cc

Issue 10967020: Turn off animations for page actions and browser actions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Now with happier tests! Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_action_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_action.cc
diff --git a/chrome/common/extensions/extension_action.cc b/chrome/common/extensions/extension_action.cc
index c857864e3267ec3c54b47d0a0d285919099a7528..e54c2559dd542b51391826edfea6ff53a1216000 100644
--- a/chrome/common/extensions/extension_action.cc
+++ b/chrome/common/extensions/extension_action.cc
@@ -319,9 +319,10 @@ bool ExtensionAction::SetAppearance(int tab_id, Appearance new_appearance) {
SetValue(&appearance_, tab_id, new_appearance);
- // When showing a badge for the first time on a web page, fade it
- // in. Other transitions happen instantly.
- if (old_appearance == INVISIBLE && tab_id != kDefaultTabId) {
+ // When showing a script badge for the first time on a web page, fade it in.
+ // Other transitions happen instantly.
+ if (old_appearance == INVISIBLE && tab_id != kDefaultTabId &&
+ action_type_ == TYPE_SCRIPT_BADGE) {
RunIconAnimation(tab_id);
}
« no previous file with comments | « no previous file | chrome/common/extensions/extension_action_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698