Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 10967020: Turn off animations for page actions and browser actions. (Closed)

Created:
8 years, 3 months ago by Jeffrey Yasskin
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Turn off animations for page actions and browser actions. The icon observation code isn't set up to watch non-script-badges, so page action animations wind up partially complete or cause a white background in script badge mode. A future refactoring to ExtensionAction should make animations work for all types, but this fix is simple to fix the problem on the Chrome 23 and maybe Chrome 22 branches. BUG=141808, 144247, 144248 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157903

Patch Set 1 #

Patch Set 2 : Now with happier tests! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M chrome/common/extensions/extension_action.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_action_unittest.cc View 1 1 chunk +34 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jeffrey Yasskin
8 years, 3 months ago (2012-09-20 20:10:55 UTC) #1
Yoyo Zhou
LGTM
8 years, 3 months ago (2012-09-20 20:30:33 UTC) #2
Yoyo Zhou
By the way, the test failures look real, but probably the expectations have changed.
8 years, 3 months ago (2012-09-20 20:31:37 UTC) #3
Jeffrey Yasskin
On 2012/09/20 20:31:37, Yoyo Zhou wrote: > By the way, the test failures look real, ...
8 years, 3 months ago (2012-09-20 22:11:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/10967020/4
8 years, 3 months ago (2012-09-20 22:14:45 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 02:33:28 UTC) #6
Change committed as 157903

Powered by Google App Engine
This is Rietveld 408576698