Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: extensions/browser/guest_view/guest_view.h

Issue 1096623002: Moved guest_view_registry to GuestViewManager and made it an instance map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch_to_frombrowsercontextifavailable
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view.h
diff --git a/extensions/browser/guest_view/guest_view.h b/extensions/browser/guest_view/guest_view.h
index 9b74df5af3c65ba415d7a3cda0a09ddded61b64a..ae6092f1c929b0fd8bcc8f836785c2b50209767f 100644
--- a/extensions/browser/guest_view/guest_view.h
+++ b/extensions/browser/guest_view/guest_view.h
@@ -8,6 +8,7 @@
#include "base/bind.h"
lazyboy 2015/04/20 19:08:57 remove?
Fady Samuel 2015/04/20 20:35:23 Done.
#include "content/public/browser/render_frame_host.h"
#include "extensions/browser/guest_view/guest_view_base.h"
+#include "extensions/browser/guest_view/guest_view_manager.h"
namespace extensions {
@@ -17,10 +18,6 @@ namespace extensions {
template <typename T>
class GuestView : public GuestViewBase {
public:
- static void Register() {
- GuestViewBase::RegisterGuestViewType(T::Type, base::Bind(&T::Create));
- }
-
static T* From(int embedder_process_id, int guest_instance_id) {
auto guest = GuestViewBase::From(embedder_process_id, guest_instance_id);
if (!guest)
« no previous file with comments | « no previous file | extensions/browser/guest_view/guest_view_base.h » ('j') | extensions/browser/guest_view/guest_view_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698