Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1096623002: Moved guest_view_registry to GuestViewManager and made it an instance map (Closed)

Created:
5 years, 8 months ago by Fady Samuel
Modified:
5 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@switch_to_frombrowsercontextifavailable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved guest_view_registry to GuestViewManager and made it an instance map This change allows for the change towards moving GuestViewManager to components and implementing an extensions specific GuestViewManager that installs extensions-specific guest types. BUG=444869 Committed: https://crrev.com/21d4d15a81b030f522fef29a0429f08a70220f68 Cr-Commit-Position: refs/heads/master@{#325919}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -62 lines) Patch
M extensions/browser/guest_view/guest_view.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 2 chunks +0 lines, -10 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 4 chunks +0 lines, -45 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.h View 1 4 chunks +21 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.cc View 1 4 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Fady Samuel
GuestViewBase now has no dependencies on extensions. GuestViewManager will next be refactored and a new ...
5 years, 8 months ago (2015-04-16 23:15:14 UTC) #2
Fady Samuel
5 years, 8 months ago (2015-04-20 15:59:30 UTC) #5
Fady Samuel
5 years, 8 months ago (2015-04-20 15:59:30 UTC) #6
Fady Samuel
OOps, assigning back to Istiaque
5 years, 8 months ago (2015-04-20 16:00:01 UTC) #8
lazyboy
https://chromiumcodereview.appspot.com/1096623002/diff/1/extensions/browser/guest_view/guest_view.h File extensions/browser/guest_view/guest_view.h (right): https://chromiumcodereview.appspot.com/1096623002/diff/1/extensions/browser/guest_view/guest_view.h#newcode8 extensions/browser/guest_view/guest_view.h:8: #include "base/bind.h" remove? https://chromiumcodereview.appspot.com/1096623002/diff/1/extensions/browser/guest_view/guest_view_manager.h File extensions/browser/guest_view/guest_view_manager.h (right): https://chromiumcodereview.appspot.com/1096623002/diff/1/extensions/browser/guest_view/guest_view_manager.h#newcode115 extensions/browser/guest_view/guest_view_manager.h:115: ...
5 years, 8 months ago (2015-04-20 19:08:57 UTC) #9
Fady Samuel
Addressed comments. PTAL https://codereview.chromium.org/1096623002/diff/1/extensions/browser/guest_view/guest_view.h File extensions/browser/guest_view/guest_view.h (right): https://codereview.chromium.org/1096623002/diff/1/extensions/browser/guest_view/guest_view.h#newcode8 extensions/browser/guest_view/guest_view.h:8: #include "base/bind.h" On 2015/04/20 19:08:57, lazyboy ...
5 years, 8 months ago (2015-04-20 20:35:23 UTC) #10
lazyboy
lgtm
5 years, 8 months ago (2015-04-20 20:39:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096623002/20001
5 years, 8 months ago (2015-04-20 20:41:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-20 22:06:08 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 22:07:34 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21d4d15a81b030f522fef29a0429f08a70220f68
Cr-Commit-Position: refs/heads/master@{#325919}

Powered by Google App Engine
This is Rietveld 408576698