Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 10966052: Added options to disable specific printers. (Closed)

Created:
8 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 2 months ago
Reviewers:
Lei Zhang, gene
CC:
chromium-reviews
Visibility:
Public.

Description

Added black list of printer. Added option to enable/disable registration of new printers. BUG=137129 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158782

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -40 lines) Patch
M chrome/common/pref_names.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.h View 4 chunks +24 lines, -25 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.cc View 1 3 chunks +15 lines, -14 lines 0 comments Download
M chrome/service/cloud_print/connector_settings.h View 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/connector_settings.cc View 2 chunks +20 lines, -1 line 0 comments Download
M chrome/service/cloud_print/connector_settings_unittest.cc View 1 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
Please review.
8 years, 2 months ago (2012-09-25 09:24:10 UTC) #1
gene
lgtm
8 years, 2 months ago (2012-09-25 17:52:05 UTC) #2
Vitaly Buka (NO REVIEWS)
Lei, may I as you review chrome/common/pref_names.* changes ?
8 years, 2 months ago (2012-09-25 17:56:05 UTC) #3
Lei Zhang
lgtm
8 years, 2 months ago (2012-09-25 18:08:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10966052/22003
8 years, 2 months ago (2012-09-26 05:12:45 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/service/cloud_print/connector_settings_unittest.cc: While running patch -p1 --forward --force; patching file chrome/service/cloud_print/connector_settings_unittest.cc ...
8 years, 2 months ago (2012-09-26 05:12:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10966052/27005
8 years, 2 months ago (2012-09-26 06:13:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10966052/27005
8 years, 2 months ago (2012-09-26 10:14:31 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 11:17:21 UTC) #9
Change committed as 158782

Powered by Google App Engine
This is Rietveld 408576698