Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 10966042: Add wrapper scripts around apply_issue.py so that it can be called directly (Closed)

Created:
8 years, 3 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Add wrapper scripts around apply_issue.py so that it can be called directly if depot tools is in the path. BUG=149941 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158039

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A apply_issue View 1 1 chunk +8 lines, -0 lines 0 comments Download
A apply_issue.bat View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Roger Tawa OOO till Jul 10th
8 years, 3 months ago (2012-09-21 19:01:27 UTC) #1
M-A Ruel
lgtm without auto-update. https://codereview.chromium.org/10966042/diff/1/apply_issue File apply_issue (right): https://codereview.chromium.org/10966042/diff/1/apply_issue#newcode8 apply_issue:8: "$base_dir"/update_depot_tools Please don't. https://codereview.chromium.org/10966042/diff/1/apply_issue.bat File apply_issue.bat ...
8 years, 3 months ago (2012-09-21 19:03:43 UTC) #2
Roger Tawa OOO till Jul 10th
Merci MA. Comments addressed, changes uploaded. I had copied that from gclient.bat/gclient. http://codereview.chromium.org/10966042/diff/1/apply_issue File apply_issue ...
8 years, 3 months ago (2012-09-21 19:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10966042/4002
8 years, 3 months ago (2012-09-21 19:09:24 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 19:11:50 UTC) #5
Change committed as 158039

Powered by Google App Engine
This is Rietveld 408576698