Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: src/lithium.h

Issue 10966031: Lowered kMaxVirtualRegisters (fixes v8 2139 and chrome 123822 and 128252). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 class LifetimeField 146 class LifetimeField
147 : public BitField<Lifetime, kLifetimeShift, kLifetimeWidth> { 147 : public BitField<Lifetime, kLifetimeShift, kLifetimeWidth> {
148 }; 148 };
149 149
150 class VirtualRegisterField 150 class VirtualRegisterField
151 : public BitField<unsigned, 151 : public BitField<unsigned,
152 kVirtualRegisterShift, 152 kVirtualRegisterShift,
153 kVirtualRegisterWidth> { 153 kVirtualRegisterWidth> {
154 }; 154 };
155 155
156 static const int kMaxVirtualRegisters = 1 << kVirtualRegisterWidth; 156 // kMaxVirtualRegisters should not exceed 1 << kVirtualRegisterWidth but we
157 // are setting it to a lower value otherwise crankshaft is too slow.
158 STATIC_ASSERT(kVirtualRegisterWidth > 13);
159 static const int kMaxVirtualRegisters = 1 << 13;
Vyacheslav Egorov (Google) 2012/09/21 11:42:08 can you give some of this bits to other fields? i
157 static const int kMaxFixedIndex = 63; 160 static const int kMaxFixedIndex = 63;
158 static const int kMinFixedIndex = -64; 161 static const int kMinFixedIndex = -64;
159 162
160 bool HasAnyPolicy() const { 163 bool HasAnyPolicy() const {
161 return policy() == ANY; 164 return policy() == ANY;
162 } 165 }
163 bool HasFixedPolicy() const { 166 bool HasFixedPolicy() const {
164 return policy() == FIXED_REGISTER || 167 return policy() == FIXED_REGISTER ||
165 policy() == FIXED_DOUBLE_REGISTER || 168 policy() == FIXED_DOUBLE_REGISTER ||
166 policy() == FIXED_SLOT; 169 policy() == FIXED_SLOT;
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 ZoneList<Handle<JSFunction> > inlined_closures_; 704 ZoneList<Handle<JSFunction> > inlined_closures_;
702 }; 705 };
703 706
704 707
705 int ElementsKindToShiftSize(ElementsKind elements_kind); 708 int ElementsKindToShiftSize(ElementsKind elements_kind);
706 709
707 710
708 } } // namespace v8::internal 711 } } // namespace v8::internal
709 712
710 #endif // V8_LITHIUM_H_ 713 #endif // V8_LITHIUM_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698