Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10966018: Make Extension::ShouldDisplayInLauncher driven by manifest property. (Closed)

Created:
8 years, 3 months ago by Marijn Kruisselbrink
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Make Extension::ShouldDisplayInLauncher driven by manifest property. BUG=148639 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/cloud_print_app/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M chrome/common/extensions/extension_manifest_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_manifest_constants.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Marijn Kruisselbrink
8 years, 3 months ago (2012-09-20 21:08:15 UTC) #1
Dan Beam
I have no idea what display_in_launcher means, but rs lgtm
8 years, 3 months ago (2012-09-21 02:16:01 UTC) #2
Aaron Boodman
On 2012/09/21 02:16:01, Dan Beam wrote: > I have no idea what display_in_launcher means, but ...
8 years, 3 months ago (2012-09-21 02:48:41 UTC) #3
asargent_no_longer_on_chrome
LGTM CL description nit: s/driver/driven/ @Dan Beam - "display in launcher" means "should this app ...
8 years, 3 months ago (2012-09-21 20:22:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/10966018/1
8 years, 3 months ago (2012-09-21 22:29:18 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-22 00:28:49 UTC) #6
Change committed as 158143

Powered by Google App Engine
This is Rietveld 408576698