Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10965013: [Chromoting] Build Chromoting Host installation in two steps: (binaries & .wxs) -> .zip -> .msi. (Closed)

Created:
8 years, 3 months ago by alexeypa (please no reviews)
Modified:
8 years, 3 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Build Chromoting Host installation in two steps: (binaries & .wxs) -> .zip -> .msi. The two step process is needed so that we could take the produced .zip and use it to sign the binaries and installation on a separate machine. Decompiling .msi using dark proved to be a bad idea due to bugs in dark.exe. BUG=146863 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157843

Patch Set 1 #

Patch Set 2 : Make sure msbuild and the custom actions use different folders. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -72 lines) Patch
M remoting/host/installer/build-installer-archive.py View 3 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/win/chromoting.wxs View 7 chunks +6 lines, -19 lines 0 comments Download
A remoting/host/win/parameters.json View 1 chunk +22 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 3 chunks +113 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alexeypa (please no reviews)
The previous attempt to land this CL failed due to tour custom actions and msbuild ...
8 years, 3 months ago (2012-09-20 16:20:25 UTC) #1
garykac
still lgtm
8 years, 3 months ago (2012-09-20 16:40:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10965013/2001
8 years, 3 months ago (2012-09-20 16:48:17 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-20 17:19:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10965013/2001
8 years, 3 months ago (2012-09-20 17:25:11 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 21:27:05 UTC) #6
Change committed as 157843

Powered by Google App Engine
This is Rietveld 408576698