Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 10965011: Allow sending frame tree updates for frames being added, even while loading. (Closed)

Created:
8 years, 3 months ago by nasko
Modified:
8 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Allow sending frame tree updates for frames being added, even while loading. We used to prevent frame tree updates during navigation from one page to another to avoid spurious updates. The goal was to not broadcast updates when we know we will be removing all the subframes when leaving a page. Allowing subframe additions to send updates allows us to support cross process calls without having to wait for all subframes to finish loading. BUG=145014 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158813

Patch Set 1 #

Patch Set 2 : Updated to LKGR. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nasko
Hey Charlie, Can you review this simplistic change? I should help us allow cross process ...
8 years, 3 months ago (2012-09-20 15:31:12 UTC) #1
Charlie Reis
LGTM. Can you update the CL description, though? It's missing the title (not sure how ...
8 years, 3 months ago (2012-09-20 18:32:36 UTC) #2
nasko
Fixed the description.
8 years, 3 months ago (2012-09-20 20:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/10965011/1
8 years, 2 months ago (2012-09-25 18:58:50 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-25 19:05:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/10965011/1
8 years, 2 months ago (2012-09-25 19:08:28 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-25 19:11:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/10965011/17001
8 years, 2 months ago (2012-09-26 15:23:03 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 16:39:34 UTC) #9
Change committed as 158813

Powered by Google App Engine
This is Rietveld 408576698