Issue 10965009: BrowserPluginGuest/Embedder: Remove friend helper classes, made necessary calls public

Issue 10965009: BrowserPluginGuest/Embedder: Remove friend helper classes, made necessary calls public (Closed)

Created:
8 years, 3 months ago by lazyboy

Modified:
8 years, 3 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

BrowserPluginGuest/Embedder: Remove friend helper classes, made necessary calls public as Charlie suggested in other review. BUG=141232 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158074

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Patch Set 3 : Sync @tott #

Patch Set 4 : Sync again @tott #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -55 lines)			Patch
M	content/browser/browser_plugin/browser_plugin_embedder.h	View	1 2	2 chunks	+22 lines, -23 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_embedder.cc	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_guest.h	View	1 2	3 chunks	+33 lines, -29 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_guest.cc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

LGTM, with one comment below. Also, please use 141232 as the bug number in the ...

8 years, 3 months ago (2012-09-20 18:24:04 UTC) #2

lazyboy

Added the relevant bug in CL description. Thanks for the review. https://chromiumcodereview.appspot.com/10965009/diff/1/content/browser/browser_plugin/browser_plugin_guest.h File content/browser/browser_plugin/browser_plugin_guest.h (right): ...

8 years, 3 months ago (2012-09-20 20:29:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/10965009/8001

8 years, 3 months ago (2012-09-21 16:02:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/10965009/13001

8 years, 3 months ago (2012-09-21 16:08:10 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/10965009/13001

8 years, 3 months ago (2012-09-21 18:31:25 UTC) #6

Change committed as 158074

Expand Messages | Collapse Messages