Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 10964059: Cancel composition on mouse clicking. (Closed)

Created:
8 years, 3 months ago by Seigo Nonaka
Modified:
8 years, 3 months ago
Reviewers:
yukawa, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, chrome-tsf_google.com, cpu_(ooo_6.6-7.5)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Cancel composition on mouse clicking. This behavior is same as desktop existing IMM32 implementation and this change only affects Metro/Chrome. We can't introduce any tests until http://codereview.chromium.org/10912171 landing. BUG=151587 TEST=Manually done one metro mode and desktop. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Seigo Nonaka
8 years, 3 months ago (2012-09-22 06:59:26 UTC) #1
Yohei Yukawa
lgtm
8 years, 3 months ago (2012-09-22 14:39:29 UTC) #2
Seigo Nonaka
Yukawa: Thank you for your review. Adding sky@ as a owner of content/browser.
8 years, 3 months ago (2012-09-22 15:23:40 UTC) #3
sky
LGTM
8 years, 3 months ago (2012-09-24 14:03:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10964059/1
8 years, 3 months ago (2012-09-24 14:30:28 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 16:55:03 UTC) #6
Change committed as 158291

Powered by Google App Engine
This is Rietveld 408576698