Call Decryptor::Stop() in FFmpegVideoDecoder::Reset().

Call Decryptor::Stop() in FFmpegVideoDecoder::Reset().

To avoid freeze when user trying to seek() when a DecrptCB is pending.

It also fix an issue that the stop_cb isn't fired when FFmpegVideoDecoder::Stop() is called when a DecryptCB is pending.

BUG=151708
TEST=added new unittest to catch this

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158457

[xhwang, 2012-09-22 01:00:49]

To fix a bug I found by thinking. The tests added proved that. PTAL!

http://codereview.chromium.org/10964055/diff/1/media/filters/ffmpeg_video_dec...
File media/filters/ffmpeg_video_decoder.cc (right):

http://codereview.chromium.org/10964055/diff/1/media/filters/ffmpeg_video_dec...
media/filters/ffmpeg_video_decoder.cc:183: decryptor_->Stop();
Maybe rename Decryptor::Stop() to something like Flush() or CancelDecrypt()?

[scherkus (not reviewing), 2012-09-23 20:01:16]

lgtm

http://codereview.chromium.org/10964055/diff/1/media/filters/ffmpeg_video_dec...
File media/filters/ffmpeg_video_decoder.cc (right):

http://codereview.chromium.org/10964055/diff/1/media/filters/ffmpeg_video_dec...
media/filters/ffmpeg_video_decoder.cc:183: decryptor_->Stop();
On 2012/09/22 01:00:49, xhwang wrote:
> Maybe rename Decryptor::Stop() to something like Flush() or CancelDecrypt()?

Agreed as Stop() is implies there's a Start() -- Flush(), Reset(), or Cancel()
all work.

[xhwang, 2012-09-24 17:27:01]

http://codereview.chromium.org/10964055/diff/1/media/filters/ffmpeg_video_dec...
File media/filters/ffmpeg_video_decoder.cc (right):

http://codereview.chromium.org/10964055/diff/1/media/filters/ffmpeg_video_dec...
media/filters/ffmpeg_video_decoder.cc:183: decryptor_->Stop();
On 2012/09/23 20:01:16, scherkus wrote:
> On 2012/09/22 01:00:49, xhwang wrote:
> > Maybe rename Decryptor::Stop() to something like Flush() or CancelDecrypt()?
> 
> Agreed as Stop() is implies there's a Start() -- Flush(), Reset(), or Cancel()
> all work.

Renamed Stop() to CancelDecrypt(). I know CancelDecrypt isn't correct English
but it makes it clear that we are cancelling decryption operations (and
DecryptCBs) scheduled by Decrypt() calls. WDYT?

[scherkus (not reviewing), 2012-09-24 20:22:33]

lgtm++

http://codereview.chromium.org/10964055/diff/1/media/filters/ffmpeg_video_dec...
File media/filters/ffmpeg_video_decoder.cc (right):

http://codereview.chromium.org/10964055/diff/1/media/filters/ffmpeg_video_dec...
media/filters/ffmpeg_video_decoder.cc:183: decryptor_->Stop();
On 2012/09/24 17:27:01, xhwang wrote:
> On 2012/09/23 20:01:16, scherkus wrote:
> > On 2012/09/22 01:00:49, xhwang wrote:
> > > Maybe rename Decryptor::Stop() to something like Flush() or
CancelDecrypt()?
> > 
> > Agreed as Stop() is implies there's a Start() -- Flush(), Reset(), or
Cancel()
> > all work.
> 
> Renamed Stop() to CancelDecrypt(). I know CancelDecrypt isn't correct English
> but it makes it clear that we are cancelling decryption operations (and
> DecryptCBs) scheduled by Decrypt() calls. WDYT?

SGTM

[commit-bot: I haz the power, 2012-09-24 21:02:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/10964055/5001

[commit-bot: I haz the power, 2012-09-24 21:02:21]

Failed to apply patch for media/filters/ffmpeg_video_decoder.cc:
While running patch -p1 --forward --force;
patching file media/filters/ffmpeg_video_decoder.cc
Hunk #3 FAILED at 249.
Hunk #4 succeeded at 325 (offset -5 lines).
1 out of 4 hunks FAILED -- saving rejects to file
media/filters/ffmpeg_video_decoder.cc.rej

[commit-bot: I haz the power, 2012-09-24 21:10:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/10964055/14001

[commit-bot: I haz the power, 2012-09-24 21:10:56]

Failed to apply patch for media/filters/ffmpeg_video_decoder.cc:
While running patch -p1 --forward --force;
patching file media/filters/ffmpeg_video_decoder.cc
Hunk #3 FAILED at 249.
Hunk #4 succeeded at 325 (offset -5 lines).
1 out of 4 hunks FAILED -- saving rejects to file
media/filters/ffmpeg_video_decoder.cc.rej

[commit-bot: I haz the power, 2012-09-24 21:16:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/10964055/16002

[commit-bot: I haz the power, 2012-09-25 00:21:46]

Change committed as 158457