Issue 10964026: Fix saved screenshots for feedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10964026: Fix saved screenshots for feedback. (Closed)

Created:
8 years, 3 months ago by rkc

Modified:
8 years, 3 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix saved screenshots for feedback. Currently the way the saved screenshots are cached is broken, causing saved screenshots to not get sent to the feedback server. This CL fixes that issue. Additionally, the default saved screenshot selection is also broken, which is also fixed. R=csilv@chromium.org BUG=148457 TEST=Send a saved screenshot from ChromeOS and verify it shows up on the feedback server. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157913

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/resources/feedback.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/screenshot_source.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10964026/1

8 years, 3 months ago (2012-09-20 22:56:55 UTC) #3

Change committed as 157913

Expand Messages | Collapse Messages