Properly flip the CGContext during UIImage->SkBitmap conversions.

Properly flip the CGContext during UIImage->SkBitmap conversions.

Skia's origin is in the upper-left whereas CG's origin is in the lower-left, so
the CGContext needs to be flipped in order to prevent the resulting image from
being upside-down.

TBR=thakis@chromium.org
BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158441

[Robert Sesek, 2012-09-24 20:27:03]

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
File ui/gfx/image/image_unittest_util_ios.mm (right):

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util_ios.mm:24: CGBitmapContextCreate(NULL, 1, 1, 8,
4,
Use kCFAllocatorDefault instead of NULL.

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util_ios.mm:24: CGBitmapContextCreate(NULL, 1, 1, 8,
4,
Can you do /*name=*/ for the params on this line?

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util_ios.mm:32: SkColor* data =
(SkColor*)CGBitmapContextGetData(bitmap_context);
reinterpret_cast<>?

[rohitrao (ping after 24h), 2012-09-24 20:39:10]

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
File ui/gfx/image/image_unittest_util_ios.mm (right):

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util_ios.mm:24: CGBitmapContextCreate(NULL, 1, 1, 8,
4,
On 2012/09/24 20:27:03, rsesek wrote:
> Use kCFAllocatorDefault instead of NULL.

The parameter is a data buffer, or NULL to make Quartz allocate a buffer for
you.

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util_ios.mm:24: CGBitmapContextCreate(NULL, 1, 1, 8,
4,
On 2012/09/24 20:27:03, rsesek wrote:
> Can you do /*name=*/ for the params on this line?

Done.

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util_ios.mm:32: SkColor* data =
(SkColor*)CGBitmapContextGetData(bitmap_context);
On 2012/09/24 20:27:03, rsesek wrote:
> reinterpret_cast<>?

Done.

[Robert Sesek, 2012-09-24 20:39:56]

LGTM

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
File ui/gfx/image/image_unittest_util_ios.mm (right):

http://codereview.chromium.org/10963064/diff/2001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util_ios.mm:24: CGBitmapContextCreate(NULL, 1, 1, 8,
4,
On 2012/09/24 20:27:03, rsesek wrote:
> Use kCFAllocatorDefault instead of NULL.

Ah my B.

[rohitrao (ping after 24h), 2012-09-24 20:43:10]

Thanks for the review.

TBR=thakis for the ui.gyp changes.

[commit-bot: I haz the power, 2012-09-24 20:43:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10963064/7001

[Nico, 2012-09-24 22:48:05]

lgtm

http://codereview.chromium.org/10963064/diff/7001/ui/gfx/image/image_unittest...
File ui/gfx/image/image_unittest_util_ios.mm (right):

http://codereview.chromium.org/10963064/diff/7001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util_ios.mm:35:
reinterpret_cast<SkColor*>(CGBitmapContextGetData(bitmap_context));
(I think the portable way to do this is bit_cast<>())

[rohitrao (ping after 24h), 2012-09-24 22:49:19]

Thanks for looking.  I'll be touching this code again in the next day or so. 
Should I change it to bit_cast in my next CL?

[Nico, 2012-09-24 22:58:49]

On Tue, Sep 25, 2012 at 7:49 AM,  <rohitrao@chromium.org> wrote:
> Thanks for looking.  I'll be touching this code again in the next day or so.
> Should I change it to bit_cast in my next CL?

We have many many reinterpret_cast<>s in our codebase, I don't think
fixing it is urgent. It was more a "fyi". If you feel like changing
this in your next CL that's cool. If you want to keep it as is, that's
cool too.

[commit-bot: I haz the power, 2012-09-24 23:28:14]

Change committed as 158441