Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3576)

Unified Diff: chrome/browser/ui/search_engines/search_engine_tab_helper.cc

Issue 10963042: Switch SearchEngineTabHelper to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: on the road again Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search_engines/search_engine_tab_helper.cc
diff --git a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
index d256a4078661f790e6b93d8155647061136875a7..4a9475633c868a8310855ba9c6f6545adaf75e24 100644
--- a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
+++ b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
@@ -23,6 +23,8 @@ using content::NavigationController;
using content::NavigationEntry;
using content::WebContents;
+int SearchEngineTabHelper::kUserDataKey;
+
namespace {
// Returns true if the entry's transition type is FORM_SUBMIT.
@@ -60,11 +62,6 @@ string16 GenerateKeywordFromNavigationEntry(const NavigationEntry* entry) {
} // namespace
-SearchEngineTabHelper::SearchEngineTabHelper(WebContents* web_contents)
- : content::WebContentsObserver(web_contents) {
- DCHECK(web_contents);
-}
-
SearchEngineTabHelper::~SearchEngineTabHelper() {
}
@@ -84,6 +81,11 @@ bool SearchEngineTabHelper::OnMessageReceived(const IPC::Message& message) {
return handled;
}
+SearchEngineTabHelper::SearchEngineTabHelper(WebContents* web_contents)
+ : content::WebContentsObserver(web_contents) {
+ DCHECK(web_contents);
+}
+
void SearchEngineTabHelper::OnPageHasOSDD(
int32 page_id,
const GURL& doc_url,
« no previous file with comments | « chrome/browser/ui/search_engines/search_engine_tab_helper.h ('k') | chrome/browser/ui/tab_contents/tab_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698