Issue 10963042: Switch SearchEngineTabHelper to use WebContentsUserData.

Issue 10963042: Switch SearchEngineTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch SearchEngineTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158161

Patch Set 2 : on the road again #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -21 lines)			Patch
M	chrome/browser/tab_contents/render_view_context_menu.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/browser_adoption.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/search_engines/search_engine_tab_helper.h	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search_engines/search_engine_tab_helper.cc	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.h	View		3 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/10963042/diff/1/chrome/browser/ui/search_engines/search_engine_tab_helper.h File chrome/browser/ui/search_engines/search_engine_tab_helper.h (right): https://codereview.chromium.org/10963042/diff/1/chrome/browser/ui/search_engines/search_engine_tab_helper.h#newcode34 chrome/browser/ui/search_engines/search_engine_tab_helper.h:34: explicit SearchEngineTabHelper(content::WebContents* web_contents); Move implementation to match new ...

8 years, 3 months ago (2012-09-21 23:31:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10963042/8001

8 years, 3 months ago (2012-09-22 00:36:18 UTC) #3

Avi (use Gerrit)

8 years, 3 months ago (2012-09-24 14:11:55 UTC) #5

https://codereview.chromium.org/10963042/diff/1/chrome/browser/ui/search_engi...
File chrome/browser/ui/search_engines/search_engine_tab_helper.h (right):

https://codereview.chromium.org/10963042/diff/1/chrome/browser/ui/search_engi...
chrome/browser/ui/search_engines/search_engine_tab_helper.h:34: explicit
SearchEngineTabHelper(content::WebContents* web_contents);
On 2012/09/21 23:31:16, sky wrote:
> Move implementation to match new position.

Done.

Expand Messages | Collapse Messages