Issue 10963040: app_list: Fix app_list_unittests crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10963040: app_list: Fix app_list_unittests crash. (Closed)

Created:
8 years, 3 months ago by xiyuan

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

app_list: Fix app_list_unittests crash. - Fix crash when enabling layers; - Fix crash when AppsGridView is tested without host widget; BUG=none. TEST=app_list_unittests should pass without crash. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158175

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	ui/app_list/apps_grid_view.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	ui/app_list/test/app_list_test_suite.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10963040/1

8 years, 3 months ago (2012-09-22 03:23:17 UTC) #3

Change committed as 158175