Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 10963037: DBus: declare property specializations (Closed)

Created:
8 years, 3 months ago by keybuk
Modified:
8 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

DBus: declare property specializations Without declaring the property specializations in the header file, the compiler can sometimes generate default constructors that don't initialize the variables correctly. BUG=none TEST=unit_tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M dbus/property.h View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
keybuk
8 years, 3 months ago (2012-09-21 19:20:23 UTC) #1
satorux1
LGTM. Wow, this is subtle.. Was this causing issues? If so, please update BUG= line.
8 years, 3 months ago (2012-09-21 19:56:00 UTC) #2
keybuk
It caused another test I tried to upload to fail On Fri, Sep 21, 2012 ...
8 years, 3 months ago (2012-09-21 19:57:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/10963037/1
8 years, 3 months ago (2012-09-21 20:06:53 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 22:55:19 UTC) #5
Change committed as 158105

Powered by Google App Engine
This is Rietveld 408576698