src/x64/lithium-codegen-x64.cc - Issue 10963032: Avoid wrong imul deopt on ia32 and x64 (fixes v8 bug 2339).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 10963032: Avoid wrong imul deopt on ia32 and x64 (fixes v8 bug 2339). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed review comments. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index cab8d377b0a1291076ffafa12aa49d38aa7e227c..8547b09be29686c301e6ad10f4d38b6c75175de8 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -1125,8 +1125,11 @@ void LCodeGen::DoMulI(LMulI* instr) {

__ testl(left, left);

__ j(not_zero, &done, Label::kNear);

Vyacheslav Egorov (Google) 2012/09/26 10:07:36 This code is redundant if right is 0. (left is alw

if (right->IsConstantOperand()) {

- if (ToInteger32(LConstantOperand::cast(right)) <= 0) {

+ if (ToInteger32(LConstantOperand::cast(right)) < 0) {

DeoptimizeIf(no_condition, instr->environment());

+ } else if (ToInteger32(LConstantOperand::cast(right)) == 0) {

+ __ cmpl(kScratchRegister, Immediate(0));

+ DeoptimizeIf(less, instr->environment());

}

} else if (right->IsStackSlot()) {

__ orl(kScratchRegister, ToOperand(right));

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | test/mjsunit/regress/regress-1117.js » ('j') | test/mjsunit/regress/regress-1117.js » ('J')