Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: src/hydrogen-instructions.h

Issue 10963010: Deopt on storing undefined into double elements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/elements-transition-hoisting.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4509 matching lines...) Expand 10 before | Expand all | Expand 10 after
4520 class HStoreKeyedFastDoubleElement 4520 class HStoreKeyedFastDoubleElement
4521 : public HTemplateInstruction<3>, public ArrayInstructionInterface { 4521 : public HTemplateInstruction<3>, public ArrayInstructionInterface {
4522 public: 4522 public:
4523 HStoreKeyedFastDoubleElement(HValue* elements, 4523 HStoreKeyedFastDoubleElement(HValue* elements,
4524 HValue* key, 4524 HValue* key,
4525 HValue* val) 4525 HValue* val)
4526 : index_offset_(0), is_dehoisted_(false) { 4526 : index_offset_(0), is_dehoisted_(false) {
4527 SetOperandAt(0, elements); 4527 SetOperandAt(0, elements);
4528 SetOperandAt(1, key); 4528 SetOperandAt(1, key);
4529 SetOperandAt(2, val); 4529 SetOperandAt(2, val);
4530 SetFlag(kDeoptimizeOnUndefined);
4530 SetGVNFlag(kChangesDoubleArrayElements); 4531 SetGVNFlag(kChangesDoubleArrayElements);
4531 } 4532 }
4532 4533
4533 virtual Representation RequiredInputRepresentation(int index) { 4534 virtual Representation RequiredInputRepresentation(int index) {
4534 if (index == 1) { 4535 if (index == 1) {
4535 return Representation::Integer32(); 4536 return Representation::Integer32();
4536 } else if (index == 2) { 4537 } else if (index == 2) {
4537 return Representation::Double(); 4538 return Representation::Double();
4538 } else { 4539 } else {
4539 return Representation::Tagged(); 4540 return Representation::Tagged();
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
5281 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex); 5282 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex);
5282 }; 5283 };
5283 5284
5284 5285
5285 #undef DECLARE_INSTRUCTION 5286 #undef DECLARE_INSTRUCTION
5286 #undef DECLARE_CONCRETE_INSTRUCTION 5287 #undef DECLARE_CONCRETE_INSTRUCTION
5287 5288
5288 } } // namespace v8::internal 5289 } } // namespace v8::internal
5289 5290
5290 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 5291 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/elements-transition-hoisting.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698