Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10962038: Fix applying git diff with new file mode 644 on a svn checkout. (Closed)

Created:
8 years, 3 months ago by M-A Ruel
Modified:
8 years, 3 months ago
Reviewers:
Peter Mayo
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, Isaac (away)
Visibility:
Public.

Description

Fix applying git diff with new file mode 644 on a svn checkout. svn propdel svn:executable shouldn't be called on it. R=petermayo@chromium.org BUG=150960 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M patch.py View 1 chunk +3 lines, -1 line 0 comments Download
M testing_support/patches_data.py View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/patch_test.py View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
8 years, 3 months ago (2012-09-21 18:53:01 UTC) #1
Peter Mayo
lgtm Something "feels" more complicated than it needs to be, but I don't seem a ...
8 years, 3 months ago (2012-09-21 19:03:49 UTC) #2
M-A Ruel
On 2012/09/21 19:03:49, Peter Mayo wrote: > lgtm > > Something "feels" more complicated than ...
8 years, 3 months ago (2012-09-21 19:05:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10962038/1
8 years, 3 months ago (2012-09-21 19:06:13 UTC) #4
shashi
thanks for the change! On 2012/09/21 19:05:44, Marc-Antoine Ruel wrote: > On 2012/09/21 19:03:49, Peter ...
8 years, 3 months ago (2012-09-21 19:09:05 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 19:09:18 UTC) #6
Change committed as 158038

Powered by Google App Engine
This is Rietveld 408576698