Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 10962030: Remove Win8 SDK header as input to the win8 check_sdk_patch target. (Closed)

Created:
8 years, 3 months ago by robertshield
Modified:
8 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Remove Win8 SDK header as input to the win8 check_sdk_patch target. BUG=150974 TEST=No gyp warning appears when using the default install path for the Windows 8 SDK. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158041

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M win8/win8.gyp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robertshield
8 years, 3 months ago (2012-09-21 15:00:49 UTC) #1
scottmg
lgtm
8 years, 3 months ago (2012-09-21 16:19:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10962030/2001
8 years, 3 months ago (2012-09-21 17:19:44 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 19:18:24 UTC) #4
Change committed as 158041

Powered by Google App Engine
This is Rietveld 408576698