Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: content/renderer/render_view_impl.cc

Issue 10962011: Allow tap gestures to open the IME on Android. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 33c5b12758630b6962c4594eaf28331cdb6b2eb0..be5bbd4ccf71e8fdfa91c58a07f80b22d61a1846 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -255,12 +255,14 @@ using WebKit::WebFindOptions;
using WebKit::WebFormControlElement;
using WebKit::WebFormElement;
using WebKit::WebFrame;
+using WebKit::WebGestureEvent;
using WebKit::WebGraphicsContext3D;
using WebKit::WebHistoryItem;
using WebKit::WebHTTPBody;
using WebKit::WebIconURL;
using WebKit::WebImage;
using WebKit::WebInputElement;
+using WebKit::WebInputEvent;
using WebKit::WebIntentRequest;
using WebKit::WebIntentServiceInfo;
using WebKit::WebMediaPlayer;
@@ -2074,6 +2076,16 @@ bool RenderViewImpl::handleCurrentKeyboardEvent() {
return did_execute_command;
}
+void RenderViewImpl::didHandleGestureEvent(const WebGestureEvent& event,
+ bool event_swallowed) {
+#if defined(OS_ANDROID)
+ if (event.type == WebInputEvent::GestureTap ||
+ event.type == WebInputEvent::GestureLongPress) {
+ UpdateTextInputState(SHOW_IME_IF_NEEDED);
+ }
+#endif
+}
+
WebKit::WebColorChooser* RenderViewImpl::createColorChooser(
WebKit::WebColorChooserClient* client,
const WebKit::WebColor& initial_color) {
@@ -5644,12 +5656,12 @@ void RenderViewImpl::OnSetFocus(bool enable) {
}
void RenderViewImpl::PpapiPluginFocusChanged() {
- UpdateTextInputState();
+ UpdateTextInputState(DO_NOT_SHOW_IME);
UpdateSelectionBounds();
}
void RenderViewImpl::PpapiPluginTextInputTypeChanged() {
- UpdateTextInputState();
+ UpdateTextInputState(DO_NOT_SHOW_IME);
if (renderer_accessibility_)
renderer_accessibility_->FocusedNodeChanged(WebNode());
}
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698