Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 10962002: Adding NativeWindow base class with no activity. (Closed)

Created:
8 years, 3 months ago by aurimas (slooooooooow)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Adding NativeWindow base class with context. This is a change from the previous CL (https://codereview.chromium.org/10916160/). It turns out that not all the Android objects that create NativeWindow will have an activity, so we need this change. BUG=116131 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158159

Patch Set 1 #

Patch Set 2 : Fixes based on dtrainor's and benm's comments #

Total comments: 2

Patch Set 3 : Nico's nit #

Patch Set 4 : Rebasing #

Patch Set 5 : adding OWNERS file #

Patch Set 6 : deleted whitespace in OWNERS #

Messages

Total messages: 12 (0 generated)
aurimas (slooooooooow)
Hey Dave, This is the same CL as downstream. Aurimas
8 years, 3 months ago (2012-09-20 23:30:39 UTC) #1
aurimas (slooooooooow)
Hey Nico, Could you take a look at this CL? Thanks, Aurimas
8 years, 3 months ago (2012-09-20 23:35:33 UTC) #2
Nico
lgtm, but it's probably good if someone on clank takes alook too. https://codereview.chromium.org/10962002/diff/2001/ui/android/java/src/org/chromium/ui/gfx/ActivityNativeWindow.java File ui/android/java/src/org/chromium/ui/gfx/ActivityNativeWindow.java ...
8 years, 3 months ago (2012-09-21 02:10:15 UTC) #3
aurimas (slooooooooow)
Hey Ben and Jay, Would you mind looking over this CL? Aurimas https://codereview.chromium.org/10962002/diff/2001/ui/android/java/src/org/chromium/ui/gfx/ActivityNativeWindow.java File ui/android/java/src/org/chromium/ui/gfx/ActivityNativeWindow.java ...
8 years, 3 months ago (2012-09-21 15:51:28 UTC) #4
benm (inactive)
lgtm
8 years, 3 months ago (2012-09-21 15:56:27 UTC) #5
Jay Civelli
lgtm
8 years, 3 months ago (2012-09-21 21:30:45 UTC) #6
aurimas (slooooooooow)
Hey Yaron, Could you take a look at my CL? I need a chrome/android owner. ...
8 years, 3 months ago (2012-09-21 21:46:44 UTC) #7
aurimas (slooooooooow)
Hey Scott, Could you take a look at my ui/ changes? Thanks, Aurimas
8 years, 3 months ago (2012-09-21 21:47:45 UTC) #8
Yaron
chrome/android lgtm we should probably have a ui/android/OWNERS file
8 years, 3 months ago (2012-09-21 22:18:12 UTC) #9
sky
LGTM
8 years, 3 months ago (2012-09-21 23:21:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/10962002/12001
8 years, 3 months ago (2012-09-21 23:26:55 UTC) #11
commit-bot: I haz the power
8 years, 3 months ago (2012-09-22 02:48:02 UTC) #12
Change committed as 158159

Powered by Google App Engine
This is Rietveld 408576698