Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 10961030: Avoid accessing uninitialized memory during DownloadManagerTest. (Closed)

Created:
8 years, 3 months ago by asanka
Modified:
8 years, 3 months ago
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Avoid accessing uninitialized memory during DownloadManagerTest. BUG=150705 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158144

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M content/browser/download/download_manager_impl_unittest.cc View 1 3 chunks +9 lines, -5 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
asanka
I verified that the DownloadCreateInfo object is no longer being dumped as a binary blob. ...
8 years, 3 months ago (2012-09-21 19:38:07 UTC) #1
Randy Smith (Not in Mondays)
LGTM.
8 years, 3 months ago (2012-09-21 20:09:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/10961030/6001
8 years, 3 months ago (2012-09-21 21:41:28 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-22 01:03:51 UTC) #4
Change committed as 158144

Powered by Google App Engine
This is Rietveld 408576698