cros: Fix crash in AppNonClientFrameViewAura::ControlView::ButtonPressed

cros: Fix crash in AppNonClientFrameViewAura::ControlView::ButtonPressed

Restoring the window via a keyboard shortcut will result in the
AppNonClientFrameViewAura being deleted but the widget with the
restore/close buttons still visible. The widget's view will have
an owner_ pointer to deleted memory, then dereference it if the
buttons are clicked.

Crash was introduced by the fix to crbug.com/147635 at crrev.com/156152

BUG=149938
TEST=added AppNonClientFrameViewAuraTest.SnapLeftClosesControls

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157918

[James Cook, 2012-09-20 19:25:51]

Scott, PTAL.  This fixes a case where the maximized app window controls can be
left onscreen when you snap the window left/right with the keyboard, which I
believe is causing a use-after-free and crash.

[sky, 2012-09-20 20:02:14]

LGTM

https://codereview.chromium.org/10961027/diff/3/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc (right):

https://codereview.chromium.org/10961027/diff/3/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc:165: const char
AppNonClientFrameViewAura::kControlWindowName[] =
Typically we put:
// static
on the line before this.

https://codereview.chromium.org/10961027/diff/3/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h (right):

https://codereview.chromium.org/10961027/diff/3/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h:43: static const
char kControlWindowName[];  // visible for test
constants should be first in a section.

[James Cook, 2012-09-20 20:06:54]

Thanks!

https://codereview.chromium.org/10961027/diff/3/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc (right):

https://codereview.chromium.org/10961027/diff/3/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc:165: const char
AppNonClientFrameViewAura::kControlWindowName[] =
On 2012/09/20 20:02:15, sky wrote:
> Typically we put:
> // static
> on the line before this.

Done.

https://codereview.chromium.org/10961027/diff/3/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h (right):

https://codereview.chromium.org/10961027/diff/3/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h:43: static const
char kControlWindowName[];  // visible for test
On 2012/09/20 20:02:15, sky wrote:
> constants should be first in a section.

Done.

[commit-bot: I haz the power, 2012-09-20 23:43:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/10961027/8002

[commit-bot: I haz the power, 2012-09-21 03:46:49]

Change committed as 157918