Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 10961021: Return primary display if out of bounds point or NULL ponter is passed to gfx::Screen::GeDisplayNea (Closed)

Created:
8 years, 3 months ago by oshima
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Return primary display if out of bounds point or NULL ponter is passed to gfx::Screen::GeDisplayNea I also changed to use just id to remember primary display. Update window resizer test to use screen coordinates. BUG=151196 TEST=covered by test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157866

Patch Set 1 : #

Patch Set 2 : fix a few other tests that were using native coordinate. it shoud use screen coordinate now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -71 lines) Patch
M ash/display/display_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_controller.cc View 13 chunks +25 lines, -27 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M ash/display/multi_display_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/display/multi_display_manager.cc View 1 5 chunks +29 lines, -28 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 6 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
8 years, 3 months ago (2012-09-20 18:55:13 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-20 19:46:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10961021/10001
8 years, 3 months ago (2012-09-20 20:36:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10961021/22
8 years, 3 months ago (2012-09-20 20:40:38 UTC) #4
oshima
On 2012/09/20 19:46:22, sky wrote: > LGTM I had to fix a few more tests. ...
8 years, 3 months ago (2012-09-20 20:47:27 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 23:17:14 UTC) #6
Change committed as 157866

Powered by Google App Engine
This is Rietveld 408576698