Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 10961020: cros: Fix mouse over-scroll animation not happening. (Closed)

Created:
8 years, 3 months ago by xiyuan
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

cros: Fix mouse over-scroll animation not happening. This is because mouse scroll event does not set scrolling_ flag. Changed to use reverting animation as a signal for bubble over-scroll animation. Also fixed a problem that bubble over-scroll animation is interrupted when mouse hovers on an item during the animation. BUG=150852 TEST=Verify that bubble over-scroll animation happens with both touch and mouse. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157905

Patch Set 1 #

Patch Set 2 : fix jumping around when mouse is hovering on an item #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M ash/wm/app_list_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_item_view.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/app_list/apps_grid_view.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/apps_grid_view.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/pagination_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/app_list/pagination_model.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
8 years, 3 months ago (2012-09-20 17:36:12 UTC) #1
xiyuan
Please hold off reviewing this CL. Found some undesirable effect and will ping again once ...
8 years, 3 months ago (2012-09-20 18:21:11 UTC) #2
xiyuan
Cl is ready for review now. Found that when widget moves during over-scroll, we actually ...
8 years, 3 months ago (2012-09-20 19:16:38 UTC) #3
sky
LGTM
8 years, 3 months ago (2012-09-20 19:51:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10961020/1004
8 years, 3 months ago (2012-09-20 22:45:57 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 02:36:46 UTC) #6
Change committed as 157905

Powered by Google App Engine
This is Rietveld 408576698