Issue 10961009: Use cfsetispeed and cfsetospeed helpers to set bitrate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10961009: Use cfsetispeed and cfsetospeed helpers to set bitrate. (Closed)

Created:
8 years, 3 months ago by petarj

Modified:
8 years, 3 months ago

Reviewers:
miket_OOO

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Use cfsetispeed and cfsetospeed helpers to set bitrate. Instead of accessing termios members directly, use the helper functions. The current code has a portability issue that is exposed when compiling for MIPS. BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157868

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/extensions/api/serial/serial_connection_posix.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/10961009/1

8 years, 3 months ago (2012-09-20 19:21:18 UTC) #3

Change committed as 157868