Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 10960039: Adding the implementation of the StreamTextureFactoryImpl for android (Closed)

Created:
8 years, 3 months ago by qinmin
Modified:
8 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Adding the implementation of the StreamTextureFactoryImpl for android This should allow embedded video to work properly BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158337

Patch Set 1 #

Patch Set 2 : remove a redudant line #

Total comments: 2

Patch Set 3 : using shared context from webkit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M content/renderer/render_view_impl.cc View 1 2 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
qinmin
PTAL
8 years, 3 months ago (2012-09-21 18:20:09 UTC) #1
jamesr
http://codereview.chromium.org/10960039/diff/3/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/10960039/diff/3/content/renderer/render_view_impl.cc#newcode2503 content/renderer/render_view_impl.cc:2503: // TODO(sievers): Expose the shared context from webkit to ...
8 years, 3 months ago (2012-09-22 00:42:22 UTC) #2
qinmin
http://codereview.chromium.org/10960039/diff/3/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/10960039/diff/3/content/renderer/render_view_impl.cc#newcode2503 content/renderer/render_view_impl.cc:2503: // TODO(sievers): Expose the shared context from webkit to ...
8 years, 3 months ago (2012-09-22 01:45:28 UTC) #3
jamesr
lgtm
8 years, 3 months ago (2012-09-22 01:56:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/10960039/3002
8 years, 3 months ago (2012-09-24 16:34:37 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 18:59:57 UTC) #6
Change committed as 158337

Powered by Google App Engine
This is Rietveld 408576698