Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Issue 10960029: Supressing unreferenced variable warning in nacl build. (Closed)

Created:
8 years, 3 months ago by bradn
Modified:
8 years, 3 months ago
Reviewers:
bbudge, brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Supressing unreferenced variable warning in nacl build. g_vlog_info_prev is not currently referenced in the nacl build of logging.cc. Cast to void to suppress warning and reduce build spew. BUG=http://code.google.com/p/chromium/issues/detail?id=148648 TEST=no spew on incremental R=bbudge@chromium.org,brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/logging.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bradn
8 years, 3 months ago (2012-09-21 09:14:13 UTC) #1
bbudge
lgtm
8 years, 3 months ago (2012-09-21 12:19:11 UTC) #2
bradn
Need OWNERS review...
8 years, 3 months ago (2012-09-21 17:33:21 UTC) #3
brettw
lgtm
8 years, 3 months ago (2012-09-22 22:54:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/10960029/1
8 years, 3 months ago (2012-09-23 01:37:49 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-23 03:53:56 UTC) #6
Change committed as 158201

Powered by Google App Engine
This is Rietveld 408576698