Browser Plugin: Implement Back, Forward, and Go.

content/browser/browser_plugin/browser_plugin_embedder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 
 #include <set>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 196 matching lines @@
       web_contents->WasShown();
     else
       web_contents->WasHidden();
   }
 }
 
 void BrowserPluginEmbedder::PluginDestroyed(int instance_id) {
   DestroyGuestByInstanceID(instance_id);
 }
 
+void BrowserPluginEmbedder::Back(int instance_id) {
+  BrowserPluginGuest* guest = GetGuestByInstanceID(instance_id);
+  if (!guest)

[lazyboy, 2012/09/20 20:05:42]

Here and below:
if (guest)
  guest->Back();

pattern is probably better?

[Fady Samuel, 2012/09/21 15:21:56]

Done.

+    return;
+  guest->Back();
+}
+
+void BrowserPluginEmbedder::Forward(int instance_id) {
+  BrowserPluginGuest* guest = GetGuestByInstanceID(instance_id);
+  if (!guest)
+    return;
+  guest->Forward();
+}
+
+void BrowserPluginEmbedder::Go(int instance_id, int relative_index) {
+  BrowserPluginGuest* guest = GetGuestByInstanceID(instance_id);
+  if (!guest)
+    return;
+  guest->Go(relative_index);
+}
+
 void BrowserPluginEmbedder::Observe(int type,
                                     const NotificationSource& source,
                                     const NotificationDetails& details) {
   switch (type) {
     case NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED: {
       bool visible = *Details<bool>(details).ptr();
       WebContentsVisibilityChanged(visible);
       break;
     }
     default:
       NOTREACHED() << "Unexpected notification type: " << type;
   }
 }
 
 }  // namespace content