Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 10959054: Switch ZoomTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, tfarina, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Switch ZoomTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158510

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -36 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_adoption.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/zoom_bubble_gtk.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.h View 3 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_observer.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 3 months ago (2012-09-22 00:34:39 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 2 months ago (2012-09-25 00:01:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10959054/4001
8 years, 2 months ago (2012-09-25 00:04:56 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 03:10:56 UTC) #4
Change committed as 158510

Powered by Google App Engine
This is Rietveld 408576698