Change visibility semantics for Instant.

chrome/browser/instant/instant_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/instant/instant_controller.h"
 
 #include "base/command_line.h"
 #include "base/i18n/case_conversion.h"
 #include "base/metrics/histogram.h"
 #include "base/time.h"
@@ skipping 368 matching lines @@
                      history::RedirectList(), last_transition_type_,
                      history::SOURCE_BROWSED, false);
   }
 
   AddPreviewUsageForHistogram(mode_, PREVIEW_COMMITTED);
 
   // We may have gotten here from CommitInstant(), which means the loader may
   // still be on the stack. So, schedule a destruction for later.
   MessageLoop::current()->DeleteSoon(FROM_HERE, loader_.release());
 
-  // This call is here to hide the preview and reset view state. It won't
-  // actually delete |loader_| because it was just released to DeleteSoon().
+  // This call is here to reset view state. It won't actually delete |loader_|
+  // because it was just released to DeleteSoon().
   DeleteLoader();
 
   return preview;
 }
 
 void InstantController::OnAutocompleteLostFocus(
     gfx::NativeView view_gaining_focus) {
   DCHECK(!is_showing_ || GetPreviewContents());
 
   // If there is no preview, nothing to do.
@@ skipping 250 matching lines @@
   DeleteLoader();
   CreateDefaultLoader();
 }
 
 void InstantController::MaybeOnStaleLoader() {
   if (!stale_loader_timer_.IsRunning())
     OnStaleLoader();
 }
 
 void InstantController::DeleteLoader() {
+  last_active_tab_ = NULL;
   last_full_text_.clear();
   last_user_text_.clear();
   last_verbatim_ = false;
   last_suggestion_ = InstantSuggestion();
   last_transition_type_ = content::PAGE_TRANSITION_LINK;
   last_match_was_search_ = false;
+  is_showing_ = false;
+  loader_processed_last_update_ = false;
   last_omnibox_bounds_ = gfx::Rect();
   url_for_history_ = GURL();
-  Hide();
   if (GetPreviewContents())
     AddPreviewUsageForHistogram(mode_, PREVIEW_DELETED);
   loader_.reset();
 }
 
 void InstantController::Show(int height, InstantSizeUnits units) {
   // Call even if showing in case height changed.
   delegate_->ShowInstant(height, units);
   if (!is_showing_) {
     is_showing_ = true;
@@ skipping 106 matching lines @@
       DCHECK(url_obj.is_valid());
       *instant_url = url_obj.spec();
     }
   }
 }
 
 bool InstantController::IsOutOfDate() const {
   return !last_active_tab_ ||
          last_active_tab_ != delegate_->GetActiveTabContents();
 }