Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10959045: Switch WebIntentPickerController to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 2 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, Avi (use Gerrit), groby+watch_chromium.org, creis+watch_chromium.org, tfarina, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, ajwong+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org
Visibility:
Public.

Description

Switch WebIntentPickerController to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158650

Patch Set 1 #

Patch Set 2 : linux #

Patch Set 3 : fix #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -101 lines) Patch
M chrome/browser/ui/browser.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration_unittest.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_intent_sheet_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 3 4 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.h View 1 2 3 6 chunks +13 lines, -5 lines 2 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 2 3 26 chunks +53 lines, -51 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 3 4 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/web_intents_button_view.cc View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
8 years, 3 months ago (2012-09-21 22:29:12 UTC) #1
James Hawkins
https://codereview.chromium.org/10959045/diff/12001/chrome/browser/ui/intents/web_intent_picker_controller.h File chrome/browser/ui/intents/web_intent_picker_controller.h (right): https://codereview.chromium.org/10959045/diff/12001/chrome/browser/ui/intents/web_intent_picker_controller.h#newcode123 chrome/browser/ui/intents/web_intent_picker_controller.h:123: static int kUserDataKey; Is this used anywhere? If so ...
8 years, 2 months ago (2012-09-25 17:46:25 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/10959045/diff/12001/chrome/browser/ui/intents/web_intent_picker_controller.h File chrome/browser/ui/intents/web_intent_picker_controller.h (right): https://codereview.chromium.org/10959045/diff/12001/chrome/browser/ui/intents/web_intent_picker_controller.h#newcode123 chrome/browser/ui/intents/web_intent_picker_controller.h:123: static int kUserDataKey; On 2012/09/25 17:46:25, James Hawkins wrote: ...
8 years, 2 months ago (2012-09-25 18:14:35 UTC) #3
James Hawkins
OK. LGTM
8 years, 2 months ago (2012-09-25 18:16:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10959045/12001
8 years, 2 months ago (2012-09-25 18:25:37 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 20:54:50 UTC) #6 
Change committed as 158650

Powered by Google App Engine
This is Rietveld 408576698