Issue 10959031: [Chromoting] Publish Chromoting Host installation as a .zip archive.

Issue 10959031: [Chromoting] Publish Chromoting Host installation as a .zip archive. (Closed)

Created:
8 years, 3 months ago by alexeypa (please no reviews)

Modified:
8 years, 2 months ago

Reviewers:
robertshield, garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Chromoting] Publish Chromoting Host installation as a .zip archive. The signing script will now use the .zip archive to build a signed host installation. This way we can avoid decompiling an .msi which is not reliable enough. BUG=146863 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158914

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : Oops, |target| and |sources| were swapped. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -262 lines)			Patch
M	build/all.gyp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/tools/build/win/FILES.cfg	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	remoting/host/win/parameters.json	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	remoting/remoting.gyp	View	1	1 chunk	+0 lines, -44 lines	0 comments	Download
D	remoting/tools/candle_and_light.py	View		1 chunk	+0 lines, -78 lines	0 comments	Download
D	remoting/tools/dark_and_candle_and_light.py	View		1 chunk	+0 lines, -73 lines	0 comments	Download
M	remoting/tools/zip2msi.py	View	1 2	7 chunks	+88 lines, -66 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

On 2012/09/20 22:58:58, alexeypa wrote: > PTAL. robertshield -> build/* and chrome/* garykac -> the ...

8 years, 3 months ago (2012-09-20 22:59:44 UTC) #2

garykac

lgtm http://codereview.chromium.org/10959031/diff/1/remoting/tools/dark_and_candle_and_light.py File remoting/tools/dark_and_candle_and_light.py (left): http://codereview.chromium.org/10959031/diff/1/remoting/tools/dark_and_candle_and_light.py#oldcode7 remoting/tools/dark_and_candle_and_light.py:7: repacked successfully.""" unpacked and repacked ...

8 years, 2 months ago (2012-09-25 23:33:07 UTC) #5

alexeypa (please no reviews)

http://codereview.chromium.org/10959031/diff/1/remoting/tools/dark_and_candle_and_light.py File remoting/tools/dark_and_candle_and_light.py (left): http://codereview.chromium.org/10959031/diff/1/remoting/tools/dark_and_candle_and_light.py#oldcode7 remoting/tools/dark_and_candle_and_light.py:7: repacked successfully.""" On 2012/09/25 23:33:07, garykac wrote: > unpacked ...

8 years, 2 months ago (2012-09-26 17:23:50 UTC) #6