Issue 10959028: Make disabled browser actions on GTK right-clickable and draggable.

Issue 10959028: Make disabled browser actions on GTK right-clickable and draggable. (Closed)

Created:
8 years, 3 months ago by Yoyo Zhou

Modified:
8 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make disabled browser actions on GTK right-clickable and draggable. BUG=150789 TEST=Use chrome.browserAction.disable to disable a browser action. Check that it is right-clickable and draggable and has the disabled appearance. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158082

Patch Set 1 #

Patch Set 2 : , #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : estade's and skia #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -14 lines)			Patch
	M	chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc	View	1 2 3	7 chunks	+34 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm https://chromiumcodereview.appspot.com/10959028/diff/4001/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc File chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc (right): https://chromiumcodereview.appspot.com/10959028/diff/4001/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc#newcode275 chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc:275: if (!enabled_) why not if (enabled_) Unset else ...

8 years, 3 months ago (2012-09-21 12:35:12 UTC) #2

Yoyo Zhou

I reworked it slightly to avoid a round-trip to Skia if the button is enabled, ...

8 years, 3 months ago (2012-09-21 18:20:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/10959028/10001

8 years, 3 months ago (2012-09-21 18:40:44 UTC) #4

Change committed as 158082

Expand Messages | Collapse Messages