Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 10959027: Make apk targets remove .class files before compile (Closed)

Created:
8 years, 3 months ago by cjhopman
Modified:
8 years, 3 months ago
Reviewers:
Yaron, Isaac (away)
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make apk targets remove .class files before compile Apk targets will package all .class files in the output directory into the apk. If a .java file is moved, the corresponding .class files might still exist in the output directory, leading to incorrect or failed builds. This forces all .java files for a target to be rebuilt when that target is rebuilt, but this is very fast. See http://crrev.com/10914080 for the same change to jar targets. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157923

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/android/ant/sdk-targets.xml View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
8 years, 3 months ago (2012-09-20 20:51:56 UTC) #1
cjhopman
Removed file that shouldn't be in this CL.
8 years, 3 months ago (2012-09-20 23:08:13 UTC) #2
Isaac (away)
lgtm, but wait for trybots to run android tests.
8 years, 3 months ago (2012-09-20 23:36:51 UTC) #3
Yaron
lgtm
8 years, 3 months ago (2012-09-20 23:57:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10959027/5010
8 years, 3 months ago (2012-09-21 00:43:55 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 03:58:09 UTC) #6
Change committed as 157923

Powered by Google App Engine
This is Rietveld 408576698