Simplify android_webview apk generation gyp rules.

Simplify android_webview apk generation gyp rules.

Common code has been moved to build/java_apk.gypi.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158265

[cjhopman, 2012-09-20 18:40:34]

http://codereview.chromium.org/10959018/diff/1/android_webview/android_webvie...
File android_webview/android_webview.gyp (right):

http://codereview.chromium.org/10959018/diff/1/android_webview/android_webvie...
android_webview/android_webview.gyp:123: ],
Line 123 should have same indent as 118.

http://codereview.chromium.org/10959018/diff/1/android_webview/android_webvie...
android_webview/android_webview.gyp:131: '<(android_strip)',
Lines 131-135 are indented an extra level.

http://codereview.chromium.org/10959018/diff/1/android_webview/android_webvie...
android_webview/android_webview.gyp:145: '<(DEPTH)/base/base.gyp:base_java',
According to
https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-d...
it seems use of <(DEPTH) is discouraged.

[mkosiba (inactive), 2012-09-21 09:53:38]

http://codereview.chromium.org/10959018/diff/1/android_webview/android_webvie...
File android_webview/android_webview.gyp (right):

http://codereview.chromium.org/10959018/diff/1/android_webview/android_webvie...
android_webview/android_webview.gyp:123: ],
On 2012/09/20 18:40:34, cjhopman wrote:
> Line 123 should have same indent as 118.

Done.

http://codereview.chromium.org/10959018/diff/1/android_webview/android_webvie...
android_webview/android_webview.gyp:131: '<(android_strip)',
On 2012/09/20 18:40:34, cjhopman wrote:
> Lines 131-135 are indented an extra level.

Done.

http://codereview.chromium.org/10959018/diff/1/android_webview/android_webvie...
android_webview/android_webview.gyp:145: '<(DEPTH)/base/base.gyp:base_java',
On 2012/09/20 18:40:34, cjhopman wrote:
> According to
>
https://groups.google.com/a/chromium.org/forum/?fromgroups=#%21topic/chromium...
> it seems use of <(DEPTH) is discouraged.

Done.

[cjhopman, 2012-09-21 16:45:49]

lgtm

[commit-bot: I haz the power, 2012-09-24 10:56:22]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[benm (inactive), 2012-09-24 10:59:13]

https://chromiumcodereview.appspot.com/10959018/diff/2003/android_webview/res...
File android_webview/res/.keep (left):

https://chromiumcodereview.appspot.com/10959018/diff/2003/android_webview/res...
android_webview/res/.keep:1: 
maybe a comment in this file to explain it? Or just add a README?

[benm (inactive), 2012-09-24 11:08:43]

lgtm

[commit-bot: I haz the power, 2012-09-24 11:08:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/10959018/10002

[commit-bot: I haz the power, 2012-09-24 11:21:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/10959018/15001

[commit-bot: I haz the power, 2012-09-24 13:23:45]

Change committed as 158265