Issue 10958058: JavaBitmap class JNI clean up, add new functionality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10958058: JavaBitmap class JNI clean up, add new functionality (Closed)

Created:
8 years, 3 months ago by trchen

Modified:
8 years, 3 months ago

Reviewers:
sky, Jesse Greenwald

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

JavaBitmap class JNI clean up, add new functionality Replaces hard-coded JNI with generated JNI. Add function to decode drawable resource from Android Framework. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158445

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase, correct gyp sort order #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -53 lines)			Patch
A	ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	ui/gfx/android/java_bitmap.h	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	ui/gfx/android/java_bitmap.cc	View		3 chunks	+41 lines, -49 lines	0 comments	Download
M	ui/ui.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

trchen

Hello I replaced the hard-coded JNI in java_bitmap.cc to generated ones. Also I added a ...

8 years, 3 months ago (2012-09-22 00:08:07 UTC) #1

sky

LGTM https://codereview.chromium.org/10958058/diff/1/ui/ui.gyp File ui/ui.gyp (right): https://codereview.chromium.org/10958058/diff/1/ui/ui.gyp#newcode839 ui/ui.gyp:839: 'android/java/src/org/chromium/ui/gfx/BitmapHelper.java', sort

8 years, 3 months ago (2012-09-24 13:46:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/10958058/6001

8 years, 3 months ago (2012-09-24 21:28:18 UTC) #3

Change committed as 158445

Expand Messages | Collapse Messages