Fix drift while scrolling.

Fix drift while scrolling.

Scrolling with one finger (particularly slow scrolling) would exhibit
drift between the scrolled amount and the finger position because
of the use of the badly-defined bounding box center as the starting
position of the scroll. Use the touch down as start position for
single-finger scroll gestures. Tested via unit-test.

BUG=150573
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158592

[rjkroege, 2012-09-21 22:49:29]

please take a look.

[rjkroege, 2012-09-21 22:50:38]

will fix white space before committing.

https://codereview.chromium.org/10958053/diff/1001/ui/base/gestures/gesture_s...
File ui/base/gestures/gesture_sequence.cc (right):

https://codereview.chromium.org/10958053/diff/1001/ui/base/gestures/gesture_s...
ui/base/gestures/gesture_sequence.cc:398: if (ScrollUpdate(event, point,
gestures.get()))
oops.

[sadrul, 2012-09-21 23:09:40]

LGTM

http://codereview.chromium.org/10958053/diff/1001/ui/aura/gestures/gesture_re...
File ui/aura/gestures/gesture_recognizer_unittest.cc (right):

http://codereview.chromium.org/10958053/diff/1001/ui/aura/gestures/gesture_re...
ui/aura/gestures/gesture_recognizer_unittest.cc:2624: EXPECT_EQ(gfx::Point(30,
30).ToString(),
Nice.

http://codereview.chromium.org/10958053/diff/1001/ui/base/gestures/gesture_se...
File ui/base/gestures/gesture_sequence.cc (right):

http://codereview.chromium.org/10958053/diff/1001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:43: // |preventDefault| on the associated
touch event.
This is also for touch-events that were processed by an aura-window or
views-view. So mentioning the preventDefault() case as an example would be
better (we have some similar comment in
GestureRecognizerImpl::AdvanceTouchQueueByOne)

[rjkroege, 2012-09-24 13:53:16]

https://codereview.chromium.org/10958053/diff/1001/ui/base/gestures/gesture_s...
File ui/base/gestures/gesture_sequence.cc (right):

https://codereview.chromium.org/10958053/diff/1001/ui/base/gestures/gesture_s...
ui/base/gestures/gesture_sequence.cc:43: // |preventDefault| on the associated
touch event.
On 2012/09/21 23:09:40, sadrul wrote:
> This is also for touch-events that were processed by an aura-window or
> views-view. So mentioning the preventDefault() case as an example would be
> better (we have some similar comment in
> GestureRecognizerImpl::AdvanceTouchQueueByOne)

Done.

https://codereview.chromium.org/10958053/diff/1001/ui/base/gestures/gesture_s...
ui/base/gestures/gesture_sequence.cc:398: if (ScrollUpdate(event, point,
gestures.get()))
On 2012/09/21 22:50:38, rjkroege wrote:
> oops.

Done.

[commit-bot: I haz the power, 2012-09-24 13:53:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10958053/6001

[commit-bot: I haz the power, 2012-09-24 14:19:05]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-25 14:40:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10958053/14001

[commit-bot: I haz the power, 2012-09-25 17:10:36]

Change committed as 158592