Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3836)

Unified Diff: chrome/service/service_process_prefs_unittest.cc

Issue 10958052: Removed unnecessary returning by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/service_process_prefs.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/service_process_prefs_unittest.cc
diff --git a/chrome/service/service_process_prefs_unittest.cc b/chrome/service/service_process_prefs_unittest.cc
index 67ac5da5607dc96b46a842362e88173dbfe7b333..0268395890dffb3531630b8cadb3dcc236f3a0a9 100644
--- a/chrome/service/service_process_prefs_unittest.cc
+++ b/chrome/service/service_process_prefs_unittest.cc
@@ -40,11 +40,7 @@ TEST_F(ServiceProcessPrefsTest, RetrievePrefs) {
prefs_->SetBoolean("testb", false); // overwrite
prefs_->SetString("tests", ""); // overwrite
prefs_->ReadPrefs();
- bool testb;
- prefs_->GetBoolean("testb", &testb);
- EXPECT_EQ(testb, true);
- std::string tests;
- prefs_->GetString("tests", &tests);
- EXPECT_EQ(tests, "testvalue");
+ EXPECT_EQ(prefs_->GetBoolean("testb", false), true);
+ EXPECT_EQ(prefs_->GetString("tests", ""), "testvalue");
}
« no previous file with comments | « chrome/service/service_process_prefs.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698