Removed unnecessary returning by reference.

chrome/service/service_process_prefs.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/service_process_prefs.h"
 
 #include "base/values.h"
 
 ServiceProcessPrefs::ServiceProcessPrefs(
     const FilePath& pref_filename,
     base::MessageLoopProxy* file_message_loop_proxy)
     : prefs_(new JsonPrefStore(pref_filename, file_message_loop_proxy)) {
 }
 
 ServiceProcessPrefs::~ServiceProcessPrefs() {}
 
 void ServiceProcessPrefs::ReadPrefs() {
   prefs_->ReadPrefs();
 }
 
 void ServiceProcessPrefs::WritePrefs() {
   prefs_->CommitPendingWrite();
 }
 
-void ServiceProcessPrefs::GetString(const std::string& key,
-                                    std::string* result) const {
+std::string ServiceProcessPrefs::GetString(const std::string& key,
+                                           const std::string& default) const {
   const Value* value;
-  if (prefs_->GetValue(key, &value) == PersistentPrefStore::READ_OK)
-    value->GetAsString(result);
+  std::string result;
+  if (prefs_->GetValue(key, &value) != PersistentPrefStore::READ_OK ||
+      !value->GetAsString(&result)) {
+    return default;
+  }
+  return result;
 }
 
 void ServiceProcessPrefs::SetString(const std::string& key,
                                     const std::string& value) {
   prefs_->SetValue(key, Value::CreateStringValue(value));
 }
 
-void ServiceProcessPrefs::GetBoolean(const std::string& key,
-                                     bool* result) const {
+bool ServiceProcessPrefs::GetBoolean(const std::string& key,
+                                     bool default) const {
   const Value* value;
-  if (prefs_->GetValue(key, &value) == PersistentPrefStore::READ_OK)
-    value->GetAsBoolean(result);
+  bool result = false;
+  if (prefs_->GetValue(key, &value) != PersistentPrefStore::READ_OK ||
+      !value->GetAsBoolean(&result)) {
+    return default;
+  }
+  return result;
 }
 
 void ServiceProcessPrefs::SetBoolean(const std::string& key, bool value) {
   prefs_->SetValue(key, Value::CreateBooleanValue(value));
 }
 
-void ServiceProcessPrefs::GetDictionary(const std::string& key,
-                                        const DictionaryValue** result) const {
+const DictionaryValue* ServiceProcessPrefs::GetDictionary(
+    const std::string& key) const {
+  const Value* value;
+  const DictionaryValue* result = NULL;
+  if (prefs_->GetValue(key, &value) != PersistentPrefStore::READ_OK ||
+      !value->IsType(Value::TYPE_DICTIONARY)) {
+    return NULL;
+  }
+
+  return static_cast<const DictionaryValue*>(value);
+}
+
+const base::ListValue* ServiceProcessPrefs::GetList(
+    const std::string& key) const {
   const Value* value;
   if (prefs_->GetValue(key, &value) != PersistentPrefStore::READ_OK ||
-      !value->IsType(Value::TYPE_DICTIONARY)) {
-    return;
+    !value->IsType(Value::TYPE_LIST)) {
+      return NULL;
   }
 
-  *result = static_cast<const DictionaryValue*>(value);
+  return static_cast<const ListValue*>(value);
 }
 
 void ServiceProcessPrefs::RemovePref(const std::string& key) {
   prefs_->RemoveValue(key);
 }
+